Skip to content

test(vm): add intvirtvm describe to e2e test dumps, change restart approval mode #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test(vm): add intvirtvm describe to e2e test dumps, change restart approval mode #1554

wants to merge 2 commits into from

Conversation

loktev-d
Copy link
Contributor

@loktev-d loktev-d commented Oct 9, 2025 •
edited
Loading

Description

Enhance the e2e test failure debugging infrastructure by adding InternalVirtualizationVirtualMachine (intvirtvm) resource descriptions to the test dump output.

Also add restartApprovalMode: Automatic to VirtualMachineRestoreForce test.

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: ci
type: fix
summary: add intvirtvm describe to e2e test dumps, change restart approval mode

@loktev-d
wip
33efba6 
Signed-off-by: Daniil Loktev <[email protected]>
@loktev-d loktev-d added this to the v1.2.0 milestone Oct 9, 2025
@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Oct 9, 2025 •
edited
Loading

Reviewer's Guide

Enhances e2e test dump utility to include describe output for InternalVirtualizationVirtualMachine resources and updates VM restore test overlays to automatically approve restarts.

File-Level Changes

Change Details Files
Add IntvirtVM describe output to e2e test dumps
  • Invoke SaveIntvirtvmDescriptions from SaveTestCaseDump
  • Implement SaveIntvirtvmDescriptions to run kubectl describe and capture stdout
  • Handle errors from describe command and file write operations
  • Write describe output to a timestamped dump file
 tests/e2e/util_test.go
Enable automatic restart approval in VM restore test overlays
  • Add patches section to set spec/disruptions/restartApprovalMode to Automatic
  • Target VirtualMachine named vm in each overlay
 tests/e2e/testdata/vm-restore-force/vm/overlays/vm-exists/kustomization.yaml
tests/e2e/testdata/vm-restore-safe/vm/overlays/vm/kustomization.yaml
tests/e2e/testdata/vm-restore-force/vm/overlays/vm-exists-always-on/kustomization.yaml
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Oct 9, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@loktev-d loktev-d changed the title test(vm): add intvirtvm describe to e2e test dumps test(vm): add intvirtvm describe to e2e test dumps, change restart approval mode Oct 9, 2025
@loktev-d loktev-d marked this pull request as draft October 9, 2025 15:08
@loktev-d loktev-d marked this pull request as ready for review October 10, 2025 12:13
@Isteb4k Isteb4k modified the milestones: v1.2.0, v1.1.1 Oct 14, 2025
@nevermarine nevermarine modified the milestones: v1.1.1, v1.2.0 Oct 16, 2025
@loktev-d
add comment
46497d3 
Signed-off-by: Daniil Loktev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@hardcoretime hardcoretime Awaiting requested review from hardcoretime hardcoretime is a code owner

@danilrwx danilrwx Awaiting requested review from danilrwx danilrwx is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@loktev-d loktev-d

Labels

None yet

Projects

None yet

Milestone

v1.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@loktev-d @nevermarine @Isteb4k